Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): rework raw sender to support dropped/conditional/split-… #722

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(builder): rework raw sender to support dropped/conditional/split-… #722

merged 1 commit into from
Jun 18, 2024
+220 −232

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Jun 12, 2024 •
edited
Loading

Fixes #295
Fixes #296

Proposed Changes

  • Remove stand-alone conditional sender. Replace with a CLI flag on the raw sender. They were almost exactly copy/paste.
  • Add new CLI argument to control which URL is used for transaction status: node or submit.
  • Add dropped status back to transaction tracker
  • Add new CLI argument to control if the raw sender supports the dropped status or not.

0xfourzerofour
0xfourzerofour approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dphilipson
dphilipson approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

bin/rundler/src/cli/builder.rs Outdated Show resolved Hide resolved
Base automatically changed from danc/sender-refactor to danc/sender-cancel June 18, 2024 21:23
Base automatically changed from danc/sender-cancel to danc/tt-polling June 18, 2024 21:39
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 24.64789% with 107 lines in your changes missing coverage. Please review.

Project coverage is 54.71%. Comparing base (1ccd847) to head (867b229).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/transaction_tracker.rs 81.30% <100.00%> (+1.74%) ⬆️
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
crates/builder/src/task.rs 0.00% <0.00%> (ø)
crates/builder/src/sender/mod.rs 0.86% <0.00%> (-0.20%) ⬇️
crates/builder/src/sender/raw.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 54.71% <24.64%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 46.27% <27.55%> (+0.51%) ⬆️
dev 0.00% <ø> (ø)
pool 65.07% <ø> (ø)
provider 16.68% <ø> (ø)
rpc 25.66% <ø> (ø)
sim 77.86% <ø> (ø)
tasks ∅ <ø> (∅)
types 65.45% <ø> (ø)
utils 18.28% <ø> (ø)

@dancoombs dancoombs changed the base branch from danc/tt-polling to danc/sender-fixes June 18, 2024 22:50
@dancoombs dancoombs merged commit e9527c5 into danc/sender-fixes Jun 18, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/fix-raw-sender branch June 18, 2024 22:50
@dancoombs dancoombs mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson dphilipson approved these changes

@alex-miao alex-miao Awaiting requested review from alex-miao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dancoombs @dphilipson @0xfourzerofour